lkml.org 
[lkml]   [2004]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6] Remove spaces from PCI IDE pci_driver.name field
On Aug 10 2004, at 01:11, Alan Cox was caught saying:
> On Maw, 2004-08-10 at 01:13, Deepak Saxena wrote:
> > Spaces in driver names show up as spaces in sysfs. Annoying.
> > I went ahead and changed ones that don't have spaces to use
> > ${NAME}_IDE so they are all consistent.
>
> I don't see the problem with spaces in the filenames. I do see the
> problem in changing stuff under people for now reason other than
> "I don't like it".
>
> The existing format with spaces looks a lot better in all the
> graphical file managers.

Files w/o spaces look better and is easier to work with if running
from cmd line, but if we ignore the "prettyness" issue, we should at
least try to be consistent. Either we have spaces and _all_ driver
names are in the format "xxx IDE", "xxx i2c", etc, or we don't allow
space at all.

~Deepak

--
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/

"Unlike me, many of you have accepted the situation of your imprisonment and
will die here like rotten cabbages." - Number 6
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.033 / U:11.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site