lkml.org 
[lkml]   [2004]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] hotplug resource limitation
On Mon, Aug 09, 2004 at 02:41:01PM +0200, Hannes Reinecke wrote:
> +#define DEBUG_KHELPER
> +

You should delete all of your debugging code before sending a patch out
:)

> + printk(KERN_INFO "khelper: max %d concurrent processes\n",
> + khelper_max);

Why always print out this info?


> diff -pur linux-2.6.8-rc2-mm2/lib/kobject.c linux-2.6.8-rc2-mm2.hotplug/lib/kobject.c
> --- linux-2.6.8-rc2-mm2/lib/kobject.c 2004-07-18 06:59:07.000000000 +0200
> +++ linux-2.6.8-rc2-mm2.hotplug/lib/kobject.c 2004-08-05 15:12:18.000000000 +0200

<snip> You really changed the kset_hotplug function, for no apparent
reason. Why?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.032 / U:19.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site