Messages in this thread | | | Date | Mon, 9 Aug 2004 21:00:42 +0200 | From | Sam Ravnborg <> | Subject | Re: [RFC] Host Virtual Serial Interface driver |
| |
On Mon, Aug 09, 2004 at 01:51:49PM -0500, Hollis Blanchard wrote: > > > > pr_debug is a noop if DEBUG is not defined. Make dump_hex, dump_packet > > be a noop also and you get rid of several #ifdef in the code. > > I'd like to do that, but notice that dump_hex() is called from dump_packet() > from hvsi_recv_response() (and I've just made hvsi_recv_control() the same). > Even with debug disabled, I'd like to be able to dump a whole packet if I get > confused...
Make a small wrapper that becomes noop in non-debug case, and use the real one where you do not care about DEBUG.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |