Messages in this thread | | | Date | Sun, 8 Aug 2004 21:50:21 +0200 | From | Pavel Machek <> | Subject | Re: Suspend/Resume support for ati-agp |
| |
Hi!
> while trying to debug a strange resume problem with 2.6.8-rc3-mm1 and > software suspend 2 I suspeced ati-agp, and created the following attached > patch to add powermanagement support for it. > > I don't know if it's the completely right thing to do, I just copied the > way via-agp and intel-agp do it - but perhaps you like it and want to send > it upstream.
Looks good to me.
> ps: > this did not fix the strange "weird vertical bars instead of movie in > mplayer after resume" I have, but does not do any bad things either > ;)
Hmm, and does it fix anything?
Pavel
> --- linux/drivers/char/agp/ati-agp.c.orig 2004-08-08 02:53:10.000000000 +0200 > +++ linux/drivers/char/agp/ati-agp.c 2004-08-08 03:06:03.000000000 +0200 > @@ -505,6 +505,33 @@ > agp_put_bridge(bridge); > } > > +#ifdef CONFIG_PM > + > +static int agp_ati_suspend(struct pci_dev *pdev, u32 state) > +{ > + pci_save_state (pdev, pdev->saved_config_space); > + pci_set_power_state (pdev, 3); > + > + return 0; > +} > + > +static int agp_ati_resume(struct pci_dev *pdev) > +{ > + struct agp_bridge_data *bridge = pci_get_drvdata(pdev); > + > + /* set power state 0 and restore PCI space */ > + pci_set_power_state (pdev, 0); > + pci_restore_state(pdev, pdev->saved_config_space); > + > + /* reconfigure AGP hardware again */ > + if (bridge->driver == &ati_generic_bridge) > + return ati_configure(); > + > + return 0; > +} > + > +#endif /* CONFIG_PM */ > + > static struct pci_device_id agp_ati_pci_table[] = { > { > .class = (PCI_CLASS_BRIDGE_HOST << 8), > @@ -524,6 +551,10 @@ > .id_table = agp_ati_pci_table, > .probe = agp_ati_probe, > .remove = agp_ati_remove, > +#ifdef CONFIG_PM > + .suspend = agp_ati_suspend, > + .resume = agp_ati_resume, > +#endif > }; > > static int __init agp_ati_init(void) -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |