Messages in this thread Patch in this message | | | Date | Sat, 7 Aug 2004 19:54:48 +0200 | From | Sam Ravnborg <> | Subject | [PATCH] kbuild: Remove LANG preset in top-level Makefile |
| |
Hi Linus, please apply before 2.6.8 final!
In the top-level Makefile a number of locale related environment variables were preset to give a small speed up when building the kernel. Unfortunately this had the bad sideeffect that the variable CFLAGS_vmlinux.lds.o lost the exported vaule in some setups (obviously not mine). This smells like a make issue - but the best solution is simply to drop presetting the locale related variables.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
===== Makefile 1.509 vs edited ===== --- 1.509/Makefile 2004-08-03 23:11:35 +02:00 +++ edited/Makefile 2004-08-07 19:44:40 +02:00 @@ -619,12 +619,7 @@ .PHONY: $(vmlinux-dirs) $(vmlinux-dirs): prepare-all scripts - $(Q)if [ ! -z $$LC_ALL ]; then \ - export LANG=$$LC_ALL; \ - export LC_ALL= ; \ - fi; \ - export LC_COLLATE=C; export LC_CTYPE=C; \ - $(MAKE) $(build)=$@ + $(Q)$(MAKE) $(build)=$@ # Things we need to do before we recursively start building the kernel # or the modules are listed in "prepare-all". - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |