Messages in this thread | | | Date | Fri, 6 Aug 2004 21:31:48 +0200 | From | Pavel Machek <> | Subject | Re: [14/25] Merge pmdisk and swsusp |
| |
Hi!
> > Moving #ifdef inside function will result with a little less code... > > Actually, we should change them to pr_debug(), like below. And, how about > makin it a config option, so one does not have to go around editing source > files to turn on the extra messages?
Looks okay, but I'm not sure if Andrew/Linus will like new config option. pr_debug() change is nice.
> BTW, many of those printk()s could use some editing to make them > meaningful to average user. ;)
Hmm, yes, that will have to happen... There's one more problem: it usually flashes for so short period that its impossible to read. Do you use serial console or high-speed camera :-)? Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |