Messages in this thread | | | Date | Wed, 4 Aug 2004 07:39:10 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] blk_queue_free_tags |
| |
On Tue, Aug 03 2004, Brian King wrote: > > -- > Brian King > eServer Storage I/O > IBM Linux Technology Center
> > Currently blk_queue_free_tags cannot be called with ops outstanding. The > scsi_tcq API defined to LLD scsi drivers allows for scsi_deactivate_tcq > to be called (which calls blk_queue_free_tags) with ops outstanding. Change > blk_queue_free_tags to no longer free the tags, but rather just disable > tagged queuing and also modify blk_queue_init_tags to handle re-enabling > tagged queuing after it has been disabled.
Not sure I completely agree with changing our exported interface just because that's what SCSI wants, but I guess there's no harm. As long as the tags are freed on queue exit, we can leave them around. I'll just make it __blk_queue_free_tags(), else applied directly.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |