Messages in this thread | | | Date | Wed, 1 Sep 2004 00:39:24 +0100 (IST) | From | Dave Airlie <> | Subject | Re: [rfc][patch] DRM initial function table support. |
| |
> > I like this. Lots. > Mostly because of this.. > > (16:14:11:davej@delerium:~)$ grep ^-# foo.diff | wc -l > 87
You think that one is good grep ^-# current_diffs | wc -l 496
is for my current CVS tree vs the in-kernel DRM ;-),
> .preinit = gamma_driver_preinit, > .pretakedown = gamma_driver_pretakedown, > .dma_ready = gamma_driver_dma_ready, > .dma_quiescent = gamma_driver_dma_quiescent, > .dma_flush_block_and_flush = gamma_flush_block_and_flush, > .dma_flush_unblock = gamma_flush_unblock, > };
With this patch it would be okay, with some of the functions I added to the table later, I had to set some defaults before calling the driver function, and also added another setting for AGP/MTRR type stuff to the device independent structure that needed to be set, I'll try and get the rest of the patches for macro removal merged up and then perhaps you could take a look at it (or take a look at CVS now) and we can cleanup the style if we still think it is necessary.. btw the setting ptrs in a fn table is the DRI/Mesa way of doing things .. so we have a bit of where two worlds collide... :-)
Dave.
-- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie pam_smb / Linux DECstation / Linux VAX / ILUG person
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |