Messages in this thread | | | Date | Tue, 31 Aug 2004 14:06:11 +0200 | From | Ingo Molnar <> | Subject | Re: [patch] lazy I/O bitmap copy for i386 (ver 2) ... |
| |
* Davide Libenzi <davidel@xmailserver.org> wrote:
> The following patch implements the lazy I/O bitmap copy for the i386 > architecture. It uses an invalid bitmap offset inside the TSS to > eventually handle the correct bitmap update in the GPF handler. The > logic is the same of the first version, plus the usage of > get/put_cpu() (thx Brian) and the nesting over the latest Ingo > variable bitmap bits.
your patch looks good to me. I believe the killer argument is what you mentioned previously, that a single GFP is cheaper than a single I/O op, so even the worst-case (an I/O app doing precisely one I/O op during its scheduling atom - very unlikely) shouldnt degrade all that much. The patch is a speedup in every other case.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |