Messages in this thread | | | Date | Mon, 30 Aug 2004 13:44:11 -0400 | From | Jeff Garzik <> | Subject | Re: [patch] libata: add ioctls to support SMART |
| |
Brad Campbell wrote: > John W. Linville wrote: > >> Support for HDIO_DRIVE_CMD and HDIO_DRIVE_TASK in libata. Useful for >> supporting SMART w/ unmodified smartctl and smartd userland binaries. >> >> Not happy w/ loop after failed ata_qc_new_init(), but needed because >> smartctl >> and smartd did not retry after failure. Likely need an option to wait >> for >> available qc? Also not sure all the error return codes are correct... >> > > YYYYYYYYYYEeeeeeeeeeeeeeeeeeeeeeeeeeehhhhhhhhhhaaaaaaaaaaaaaaaaaaa!!!!!!!! > > I know it's a bit kludgy and does not really fit the philosophy of > libata but it works and it lets me keep an eye on my drives *now*. > > Although just for good measure I'll probably unmount and stop my raid > arrays before I use it on the disks. Whats it like for locking on a busy > system?
I wouldn't trust it on a busy system yet -- it submits the command to the device without checking if there is a command already outstanding.
The patch could _definitely_ corrupt data or lock your hardware, since it bypasses the SCSI mechanism that ensures that only one command is executing at a time.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |