lkml.org 
[lkml]   [2004]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch for review] BSD accounting IO stats
Andi Kleen wrote:

>>diff -uprN -X dontdiff linux-2.6.8-rc2/drivers/block/ll_rw_blk.c linux-2.6.8-rc2+BSDacct_IO/drivers/block/ll_rw_blk.c
>>--- linux-2.6.8-rc2/drivers/block/ll_rw_blk.c 2004-07-18 06:57:42.000000000 +0200
>>+++ linux-2.6.8-rc2+BSDacct_IO/drivers/block/ll_rw_blk.c 2004-07-27 09:17:33.149321480 +0200
>>@@ -1949,10 +1949,12 @@ void drive_stat_acct(struct request *rq,
>>
>> if (rw == READ) {
>> disk_stat_add(rq->rq_disk, read_sectors, nr_sectors);
>>+ current->rblk += nr_sectors;
>>
>>
>
>This doesn't look very useful, because most writes which
>are flushed delayed would get accounted to pdflushd.
>Using such inaccurate data for accounting sounds quite dangerous
>to me.
>
>
I agree with that. Like you and Andrew said, this metric (write block)
is just an estimate (quite wrong indeed) of what really occurred in the
system because some writings are accounted elsewhere (pdflush or
journaling file system).

I also agree that a rough estimation is not very interesting, therefore
I'm working on another patch to provide accurate values.

Best,
Guillaume
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.258 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site