lkml.org 
[lkml]   [2004]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][1/4] b44: Ignore carrier lost errors
    Date
    Hi,

    some (?) hardware seems to be buggy and is reporting bogus carrier lost
    values. Both reference implementations from Broadcom indicate that this
    counter is not reliable and therefore ignore it. We should do the same.
    "Fixes" the carrier lost problem i've seen.

    Regards,
    Florian

    Signed-off-by: Florian Schirmer <jolt@tuxbox.org>

    --- linux/drivers/net/b44.c-old1 2004-08-29 16:29:08.000000000 +0200
    +++ linux/drivers/net/b44.c 2004-08-29 16:27:00.000000000 +0200
    @@ -1347,7 +1347,10 @@ static struct net_device_stats *b44_get_
    hwstat->rx_symbol_errs);

    nstat->tx_aborted_errors = hwstat->tx_underruns;
    +#if 0
    + /* Carrier lost counter seems to be broken for some devices */
    nstat->tx_carrier_errors = hwstat->tx_carrier_lost;
    +#endif

    return nstat;
    }
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:3.475 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site