lkml.org 
[lkml]   [2004]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [1/4] standardize bit waiting data type
    William Lee Irwin III <wli@holomorphy.com> wrote:
    >
    > William Lee Irwin III <wli@holomorphy.com> wrote:
    > >> void fastcall unlock_page(struct page *page)
    > >> {
    > >> + unsigned long *word = (unsigned long *)&page->flags;
    >
    > On Fri, Aug 27, 2004 at 11:17:13PM -0700, Andrew Morton wrote:
    > > This will break if a little-endian 64-bit architecture elects to use a
    > > 32-bit page_flags_t.
    >
    > You mean a big-endian one? I did check to be sure none did so; only
    > x86-64 does. Easy enough to dress up so BE arches can do it too.
    >

    hm. Actually, the page_flags_t hack can only work on little-endian
    hardware anyway.

    perhaps your implementation should imitate x86_64/bitops.h and use a void*,
    along with apologetic comments.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.020 / U:0.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site