lkml.org 
[lkml]   [2004]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kallsyms data size reduction / lookup speedup
On Wed, 25 Aug 2004 22:51:13 +0200 Sam Ravnborg wrote:

| On Wed, Aug 25, 2004 at 05:04:46AM +0100, pmarques@grupopie.com wrote:
| >
| > This patch is an improvement over my first kallsyms speedup patch posted about 2
| > weeks ago.
|
| My origianl comment still hold.
| Decoupling the compression and decompression part is not good.
| Better keep them close to each other.
|
| Why not put all symbols in an __init section, compress them during kernel boot
| and then the original section get discarded.
|
| After a quick browse of the code.
| - Use spaces around '=' etc.

I just want to emphasize Sam's last comment. Find and use that
'spacebar' thingy a lot more. Make the code human-readable, not
just machine-readable.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.082 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site