Messages in this thread | | | Date | Wed, 25 Aug 2004 13:58:54 -0500 | From | Matt Mackall <> | Subject | Re: [PATCH] kallsyms data size reduction / lookup speedup |
| |
On Wed, Aug 25, 2004 at 07:46:53PM +0100, Paulo Marques wrote: > Matt Mackall wrote: > >On Wed, Aug 25, 2004 at 05:04:46AM +0100, pmarques@grupopie.com wrote: > > > >>As always, comments, suggestions, flames will be greatly appreciated :) > > > > > >Please post patches inline so they're easier to comment on. > >Attachments are a nuisance. > > Sorry about that. I've had problems in the past with my email client > word wrapping patches, so to be sure the patch goes untouched I sent it > this way. > > Since I've changed email client since then, next time I'll try inlining > again. > > >Am I correct that this is completely replacing stem compression with > >your substring dictionary approach? > > Yes, you are correct. > > Right now I'm working on making the proc interface more eficient by > removing all the seq_file stuff, that was needed because of the O(n) > lookup time we had previously.
FYI, killing the seq_file stuff will likely prove unpopular. So you'll want to do that in a separate patch. If it doesn't affect the way you're handling compression, please repost your compression patch. I have a few comments, but otherwise I think we should move forward with it.
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |