Messages in this thread | | | From | Bjorn Helgaas <> | Subject | Re: 2.6.8.1-mm2 (nvidia breakage) | Date | Tue, 24 Aug 2004 09:26:42 -0600 |
| |
On Monday 23 August 2004 1:01 pm, Terence Ripperda wrote: > On Mon, Aug 23, 2004 at 09:30:18AM -0600, bjorn.helgaas@hp.com wrote: > > Of course, the nvidia driver still won't work > > because it's looking at pci_dev->irq before calling pci_enable_device(), > > but that's a separate issue. > > as Alan pointed out, the video device is bios configured, so may not > be hit by this. nonetheless, we've applied a patch along these lines > to our internal codebase.
To be pedantically clear about this, looking at pci_dev->irq before calling pci_enable_device() is *guaranteed* to fail, regardless of what the BIOS does. So nvidia users will have to use "pci=routeirq" until there's a new version of the nvidia driver.
Alan was specifically referring to the BAR configuration that may be done by the BIOS.
I'm assuming your patch makes the driver call pci_enable_device() before using either irq or BAR information. That's the best way to future-proof the driver. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |