lkml.org 
[lkml]   [2004]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Speed up the cdrw packet writing driver
On Sat, Aug 14 2004, Peter Osterlund wrote:
> Hi!
>
> This patch replaces the pd->bio_queue linked list with an rbtree. The
> list can get very long (>200000 entries on a 1GB machine), so keeping
> it sorted with a naive algorithm is far too expensive.

It looks like you are assuming that bio->bi_sector is unique which isn't
necessarily true. In that respect, list -> rbtree conversion isn't
trivial (or, at least it requires extra code to handle this).

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.166 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site