Messages in this thread | | | Date | Mon, 23 Aug 2004 13:43:29 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] Speed up the cdrw packet writing driver |
| |
On Sat, Aug 14 2004, Peter Osterlund wrote: > Hi! > > This patch replaces the pd->bio_queue linked list with an rbtree. The > list can get very long (>200000 entries on a 1GB machine), so keeping > it sorted with a naive algorithm is far too expensive.
It looks like you are assuming that bio->bi_sector is unique which isn't necessarily true. In that respect, list -> rbtree conversion isn't trivial (or, at least it requires extra code to handle this).
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |