Messages in this thread | | | Date | Tue, 24 Aug 2004 02:18:22 +0100 | From | Dave Jones <> | Subject | Re: [PATCH] Writeback page range hint |
| |
On Mon, Aug 23, 2004 at 06:14:00PM -0700, Andrew Morton wrote:
> > > + int nonblocking:1; /* Don't get stuck on request queues */ > > > + int encountered_congestion:1; /* An output: a queue is full */ > > > + int for_kupdate:1; /* A kupdate writeback */ > > > + int for_reclaim:1; /* Invoked from the page allocator */ > > > > Causes sparse spew.. > > > > include/linux/writeback.h:54:19: warning: dubious one-bit signed bitfield > > include/linux/writeback.h:55:30: warning: dubious one-bit signed bitfield > > include/linux/writeback.h:56:19: warning: dubious one-bit signed bitfield > > include/linux/writeback.h:57:19: warning: dubious one-bit signed bitfield > > That's fussy of it. I assume this shuts it up?
very likely (its 2am, and I'm feeling too lazy to check). though, is there any real reason why they are bitfields at all ?
I'll double check it in the morning when the nightly sparse cron jobs mail me 8-)
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |