Messages in this thread | | | Date | Mon, 23 Aug 2004 19:49:36 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH][1/7] xattr consolidation - libfs |
| |
On Mon, Aug 23, 2004 at 02:15:15PM -0400, James Morris wrote: > This patch consolidates common xattr handling logic into libfs, for > use by ext2, ext3 and devpts, as well as upcoming ramfs and tmpfs xattr code.
Please don't do it this way. By making the xattr handlers constant for a superblock's lifetime you can get rid of all the locking, and the arbitrary limit on the number of xattrs. Please also move the code to xattr.c where it belong (long-term I'd like to kill the old inode ops so we can do things like moving the permission checks for user xattrs into common code where they belong)
Also s/simple_// for most symbols as this stuff isn't simple, in fact it's quite complex :)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |