Messages in this thread | | | Date | Sun, 22 Aug 2004 11:00:20 -0400 (EDT) | From | Zwane Mwaikambo <> | Subject | Re: [PATCH][2.6] Hotplug cpu: Fix APIC queued timer vector race |
| |
On Sun, 22 Aug 2004, Zwane Mwaikambo wrote:
> On Sun, 22 Aug 2004, Rusty Russell wrote: > > > On Sun, 2004-08-22 at 00:10, Zwane Mwaikambo wrote: > > > Some timer interrupt vectors were queued on the Local APIC and were being > > > serviced when we enabled interrupts again in fixup_irqs(), so we need to > > > mask the APIC timer, enable interrupts so that any queued interrupts get > > > processed whilst the processor is still on the online map and then clear > > > ourselves from the online map. 1ms is a nice safe number even under heavy > > > interrupt load with higher priority vectors queued. Andrew this is > > > the patch i promised, Rusty, i'm not sure if you find > > > __attribute__((weak)) offensive... > > > > It's horrible. Please move the unsetting of the cpu_online bit into the > > arch-specific __cpu_disable() code for each arch, which is consistent > > and also simplifies things. > > Alright this should do it then;
I'll sync against -mm shortly
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |