Messages in this thread | | | Subject | Re: [PATCH] notify_parent and ptrace cleanup | From | OGAWA Hirofumi <> | Date | Sat, 21 Aug 2004 20:47:55 +0900 |
| |
Roland McGrath <roland@redhat.com> writes:
> + spin_unlock_irq(¤t->sighand->siglock);
This unlock is odd. lock is missing?
> + read_lock(&tasklist_lock); > + do_notify_parent_cldstop(current, current->parent); > + read_unlock(&tasklist_lock); > + schedule(); > + > + /* We are back. */ > + current->last_siginfo = NULL; > +}
->last_siginfo is racy. Please, really please don't extend it until the race condition is fixed.
SIGCONT restart the stopped task. Any lock doesn't prevent it. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |