lkml.org 
[lkml]   [2004]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.8.1-mm1
From
Date
Christoph Hellwig <hch@infradead.org> writes:

> On Thu, Aug 19, 2004 at 01:57:09AM +0200, Peter Osterlund wrote:
> > That can actually be avoided by letting the packet driver itself keep
> > track of how many unfinished bios there are in the CD request queue.
> > This is straightforward to implement. The only small complication is
> > that incoming read requests need to be cloned so that the packet
> > driver can use a private bi_end_io function.
>
> Neat, this looks pretty good. Other comments on the pkt driver (not related
> to this patch):
>
> in the blockdev ->open/->release->ioctl you can get your private data
> from inode->i_bdev->bd_disk->private_data instead of doing the lookup.

The release/ioctl functions should be no problems to convert, but how
do I prevent pkt_open() and pkt_remove_dev() from racing against each
other with your suggestion? Currently this is handled by the ctl_mutex
and the fact that pkt_find_dev_from_minor() returns NULL if the packet
device has gone away.

--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.089 / U:2.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site