Messages in this thread | | | Date | Mon, 2 Aug 2004 19:32:06 -0700 (PDT) | From | Jon Smirl <> | Subject | Re: [PATCH] add PCI ROMs to sysfs |
| |
My original version have this in it:
/* assign the ROM an address if it doesn't have one */ if (r->parent == NULL) pci_assign_resource(dev->pdev, PCI_ROM_RESOURCE); if (r->parent) { release_resource(r); r->flags &= ~PCI_ROM_ADDRESS_ENABLE; r->end -= r->start; r->start = 0; }
I was running this code on both 2.4/2.6 but I may have needed to do this for 2.4. Is it consistent to have pci_assign_resource() and then use release_resource()?
My i875P AGP controller has a ROM on it as well as my two video cards.
--- Jesse Barnes <jbarnes@engr.sgi.com> wrote:
> On Monday, August 2, 2004 4:30 pm, Alan Cox wrote: > > What guarantees the ROM already has an assigned PCI address ? > > Presumably the PCI core. If that's a bad assumption, then clearly > this code > won't work as is and will need additional checks/setup code. > > Jesse >
===== Jon Smirl jonsmirl@yahoo.com
__________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |