Messages in this thread | | | Subject | Re: [PATCH] use for_each_cpu | From | Rusty Russell <> | Date | Mon, 02 Aug 2004 15:59:55 +1000 |
| |
On Sun, 2004-08-01 at 17:47, Andrew Morton wrote: > > Is it worth adding complexity to the cpu > > notifiers vs just using for_each_cpu? > > yup ;) It's only six lines, and it follows the same pattern as is used in, > say, page_alloc_cpu_notify(). Doing the same thing the same way in > multiple places is to be preferred, yes?
Yes, and that way is "for_each_cpu".
Andrew, take his patch. You know for_each_cpu is preferred over for_each_online_cpu unless there's a good reason for the latter.
Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |