lkml.org 
[lkml]   [2004]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.8.1-mm1 broke USB driver with ACPI pci irq routing... info follows
From
Date
On Wed, 2004-08-18 at 19:40, Bjorn Helgaas wrote:

> Make acpi_irq_penalty non-initdata, since it's used by the
> non_init acpi_pci_link_allocate().

hmmm, now that we need to keep this around, we might consider squeezing
it down to, say 64 bytes. This stuff will probably never run for IRQs >
64 and probably a byte/level is enough.

> And make acpi_irq_penalty_init()
> __init, since it is used only by the __init pci_acpi_init().
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

I'll apply this Bjorn.

I have to complement you on your paranoia to
1. keep acpi_pci_irq_enable(dev) for all devices in 2.6.8
2. add pci=routeirq to diagnose the breakage when you took it out

thanks,
-Len


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.033 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site