lkml.org 
[lkml]   [2004]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][linux-usb-devel] Early USB handoff
On Mon, 16 Aug 2004 19:09:53 -0700
"Aleksey Gorelov" <Aleksey_Gorelov@Phoenix.com> wrote:

> Attached is a patch for 2.6.8.1

This looks good, however I'd like you to make spacing more kernel-like,
for example here:

> + writel( 0x3f, op_reg_base + EHCI_USBSTS);
> + udelay( delta);

Also, the double star has to go:

/**
* foo
*/

It might confuse scripts which generate Docbook manuals.

Once you're done, we only have to wait for Greg to get back from
vacation, pipe through him into -mm and have someone actually
testing it on the IBM's Itanium NUMA for confirmation that it
actually worked. Only then Linus will take it, and I'll take it
for Marcelo. Kind of long way, but there you have it...
I'll feed it to Dell people too, I know they suffered from it.

BTW, why is that you awarded EHCI its own function, but not UHCI or OHCI?

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.047 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site