lkml.org 
[lkml]   [2004]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] notify_parent cleanup
> Roland McGrath <roland@redhat.com> writes:
>
> > > Roland McGrath <roland@redhat.com> writes:
> > > > + BUG_ON(tsk->state != TASK_STOPPED);
> > >
> > > task->state is changed anytime, right? Although the window is small,
> > > I think we should remove it at least for right now.
>
> > I put it there intending just to ensure that all the code paths
> > were the stopping ones, as all the extant ones are.
>
> Ah, I see.
>
> Instead of BUG_ON(), how about WARN_ON() for debug? Since window is
> small...

It's small but certainly valid. I think it's better to leave the assertion
out entirely for the moment, and just revamp this so that notify_parent as
such no longer exists.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.052 / U:4.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site