lkml.org 
[lkml]   [2004]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] notify_parent cleanup
> Roland McGrath <roland@redhat.com> writes:
>
> > void
> > notify_parent(struct task_struct *tsk, int sig)
>
> [...]
>
> > + BUG_ON(tsk->state != TASK_STOPPED);
>
> task->state is changed anytime, right? Although the window is small,
> I think we should remove it at least for right now.

You are right. That assertion is not safe. I put it there intending just
to ensure that all the code paths were the stopping ones, as all the extant
ones are. But in fact there is the race you mention, and the test should
not be there.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.101 / U:1.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site