Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: IDE hackery: lock fixes and hotplug controller stuff | Date | Thu, 12 Aug 2004 19:12:35 +0200 |
| |
On Tuesday 10 August 2004 20:23, Alan Cox wrote: > On Tue, Aug 10, 2004 at 07:16:17PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Tuesday 10 August 2004 18:19, Alan Cox wrote: > > > - Remove unsafe and essentially unfixable proc code for flipping > > > between ide-cd and ide-scsi. Its no longer relevant with SG_IO. > > > > Shouldn't we deprecate it first...? > > It doesn't work now so it clearly isnt being used 8). We hold the lock > because its a proc function and we then replace the proc functions in the > attach method -> deadlock. It is also incredibly hard to fix without a > major rewrite.
It is a correct analysis for /proc/ide/hdx/settings:ide-scsi but not for /proc/ide/hdx/driver which works just fine (modulo being racy) and your patch removes both interfaces...
Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |