lkml.org 
[lkml]   [2004]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH][2.6] Completely out of line spinlocks / i386
Date
On Wed, 11 Aug 2004 15:13:15 -0700 (PDT), 
Linus Torvalds <torvalds@osdl.org> wrote:
>
>
>On Wed, 11 Aug 2004, Pavel Machek wrote:
>>
>> Fine, so perhaps we do not want config option?
>
>The inline spinlocks are _wonderful_ for seeing where the contention is in
>a simple profile.
>
>In contrast, in a profile the out-of-lines ones will show "x% was spent on
>spinlocks". Which doesn't help much when you want to see where the problem
>is.
>
>This was _hugely_ useful, at least for me, for seeing what locks were
>problematic.

Tweak the profile code to detect that the instruction pointer is in the
out of line spinlock code and replace the ip with the caller's ip. We
already do that for ia64, where the out of line spinlock code is a big
win. A kdb backtrace on an ia64 contended lock will even decode the
address of the lock, which is only possible because the lock address is
in a known location for this case.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.065 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site