Messages in this thread Patch in this message |  | | From | David Brownell <> | Subject | Re: uhci-hcd oops with 2.4.27/ intel D845GLVA | Date | Wed, 11 Aug 2004 00:16:43 -0700 |
| |
On Tuesday 10 August 2004 10:02 pm, Pete Zaitcev wrote: > On Tue, 10 Aug 2004 21:37:26 -0700 > David Brownell <david-b@pacbell.net> wrote: > > > > First, it fixes the oops in the scan_async. > > > > That's a NOP, ehci->async must never be null. > > This is news. I received this patch FROM YOU. And I shipped it with > RHEL3 U3. And now it's a nop? What gives?! By the way, it's verified > to fix the oops when handoff fails.
I see what was going on -- that patch somehow got lost. It normally never IS null, except on an exotic fault path during initialization. Which of course nobody ever sees ... right :)
- Dave
> > > +++ linux-2.4.21-17.EL-usb1/drivers/usb/host/ehci-hcd.c 2004-07-30 16:21:12.000000000 -0700 > > > @@ -547,7 +547,8 @@ > > > > > > /* root hub is shut down separately (first, when possible) */ > > > spin_lock_irq (&ehci->lock); > > > - ehci_work (ehci, NULL); > > > + if (ehci->async) > > > + ehci_work (ehci, NULL); > > > spin_unlock_irq (&ehci->lock); > > Please look at this: > http://www.ussg.iu.edu/hypermail/linux/kernel/0404.2/0156.html > > -- Pete > > P.S. Sorry to get your name wrong, David. > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |