Messages in this thread Patch in this message | | | Date | Wed, 11 Aug 2004 17:38:12 -0400 (EDT) | From | Zwane Mwaikambo <> | Subject | RE: [PATCH][2.6] fix i386 idle routine selection |
| |
On Wed, 11 Aug 2004, Pallipadi, Venkatesh wrote:
> Agreed that handling asymmetric CPUs here is a bit of overkill. > We can stick to the original patch + few more cleanups (attached).
Ah yes, the comment needs updating to the fact that the code has changed. I've rediffed this against 2.6.8-rc4-mm1
Thanks
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> Signed-off-by: Zwane Mwaikambo <zwane@linuxpower.ca>
Index: linux-2.6.8-rc4-mm1/arch/i386/kernel/process.c =================================================================== RCS file: /home/cvsroot/linux-2.6.8-rc4-mm1/arch/i386/kernel/process.c,v retrieving revision 1.1.1.1 diff -u -p -B -r1.1.1.1 process.c --- linux-2.6.8-rc4-mm1/arch/i386/kernel/process.c 10 Aug 2004 14:49:26 -0000 1.1.1.1 +++ linux-2.6.8-rc4-mm1/arch/i386/kernel/process.c 11 Aug 2004 21:37:29 -0000 @@ -218,9 +218,7 @@ void __init select_idle_routine(const st printk("monitor/mwait feature present.\n"); /* * Skip, if setup has overridden idle. - * Also, take care of system with asymmetric CPUs. - * Use, mwait_idle only if all cpus support it. - * If not, we fallback to default_idle() + * One CPU supports mwait => All CPUs supports mwait */ if (!pm_idle) { printk("using mwait in idle threads.\n"); Index: linux-2.6.8-rc4-mm1/arch/x86_64/kernel/process.c =================================================================== RCS file: /home/cvsroot/linux-2.6.8-rc4-mm1/arch/x86_64/kernel/process.c,v retrieving revision 1.1.1.1 diff -u -p -B -r1.1.1.1 process.c --- linux-2.6.8-rc4-mm1/arch/x86_64/kernel/process.c 10 Aug 2004 14:49:30 -0000 1.1.1.1 +++ linux-2.6.8-rc4-mm1/arch/x86_64/kernel/process.c 11 Aug 2004 21:36:57 -0000 @@ -169,9 +169,7 @@ void __init select_idle_routine(const st if (cpu_has(c, X86_FEATURE_MWAIT)) { /* * Skip, if setup has overridden idle. - * Also, take care of system with asymmetric CPUs. - * Use, mwait_idle only if all cpus support it. - * If not, we fallback to default_idle() + * One CPU supports mwait => All CPUs supports mwait */ if (!pm_idle) { if (!printed) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |