lkml.org 
[lkml]   [2004]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] add PCI ROMs to sysfs
Date
On Friday, August 6, 2004 2:14 pm, Jon Smirl wrote:
> Please check the code out and give it some testing. It will probably
> needs some adjustment for other platforms.

Jon, this works on my machine too. Greg, if it looks ok can you pull it in?
And can you add:

* (C) Copyright 2004 Silicon Graphics, Inc.
* Jesse Barnes <jbarnes@sgi.com>

to pci-sysfs.c if you do?

Greg was a little worried that your comment
/* .size is set individually for each device, sysfs copies it into dentry */
might not be correct. If not, you can reuse the code from my
pci-sysfs-rom-7.patch if you want, otherwise it's probably fine aside from a
bunch of trailing whitespace in the file. I added the following to my .emacs
to make it obvious so that I could kill it when I saw it:
(defun linux-c-mode ()
"C mode with Linux kernel defaults"
(interactive)
(c-mode)
(c-set-style "K&R")
(setq c-basic-offset 8)
(setq indent-tabs-mode t)
(setq show-trailing-whitespace t))

Thanks,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.107 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site