Messages in this thread | | | Date | Tue, 10 Aug 2004 03:32:22 -0700 | From | William Lee Irwin III <> | Subject | Re: [patch] preempt-timing-on-2.6.8-rc3-O4.patch |
| |
On Tue, Aug 10, 2004 at 12:13:03PM +0200, Ingo Molnar wrote: >> i've uploaded a new version of the preempt-timing patch: >> http://redhat.com/~mingo/voluntary-preempt/preempt-timing-on-2.6.8-rc3-O4.patch >> this patch fixes a number of false positives and false negatives. In >> particular it fixes the idle-task false positives, and it now correctly >> measures preemption delays in softirq and hardirq contexts and in >> bh-disabled process contexts. Maybe this sheds a light on some of the >> more mysterious delays that we've seen. (and which were never directly >> measured before.) >> (the patch also got alot simpler, which should help portability.)
On Tue, Aug 10, 2004 at 03:20:19AM -0700, William Lee Irwin III wrote: > Looks really good, this thing is really starting to look slick from all > the time you've put in on it. > The adding in of the FOOIRQ_OFFSET bits were a rather major oversisght > on my part! Very good catch.
Feh, there has to be a way to say "this is a good patch" without sounding like I'm reviewing freshman code. This is a good patch.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |