[lkml]   [2004]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] use for_each_cpu
Anton Blanchard <> wrote:
> > > The per cpu schedule counters need to be summed up over all possible cpus.
> > > When testing hotplug cpu remove I saw the sum of the online cpu count
> > > for nr_uninterruptible go negative which made the load average go nuts.
> >
> > I think the preferred approach here is to transfer the count over to the
> > current CPU in the CPU_DEAD handler.
> They only look to be called out of proc, and once every 5 seconds for
> loadaverage calculations.


> Is it worth adding complexity to the cpu
> notifiers vs just using for_each_cpu?

yup ;) It's only six lines, and it follows the same pattern as is used in,
say, page_alloc_cpu_notify(). Doing the same thing the same way in
multiple places is to be preferred, yes?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 14:04    [W:0.036 / U:0.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site