Messages in this thread | | | Subject | Re: GCC 3.4 and broken inlining. | From | Nigel Cunningham <> | Date | Fri, 09 Jul 2004 14:56:43 +1000 |
| |
Hi.
On Fri, 2004-07-09 at 14:51, Andi Kleen wrote: > Nigel Cunningham <ncunningham@linuxmail.org> writes:
I'm not sure what I wrote that you're replying to.
> I think a better solution would be to apply the appended patch
I'm going to be a pragmatist :> As long as it works. I do think that functions being declared inline when they can't be inlined is wrong, but there are more important things on which to spend my time.
> And then just mark the function you know needs to be inlined > as __always_inline__. I did this on x86-64 for some functions > too that need to be always inlined (although using the attribute > directly because all x86-64 compilers support it)
Should that be __always_inline (no final __ in the patch below, so far as I can see)?
[...]
> P.S.: compiler.h seems to be not "gcc 4.0 safe". Probably that needs > to be fixed too.
Yes.
Regards,
Nigel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |