lkml.org 
[lkml]   [2004]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] CDRW packet writing support for 2.6.7-bk13
On Mon, Jul 05 2004, Peter Osterlund wrote:
> > All in all I really wonder whether a separate driver is really that
> > a good fit for the functionality or whether it should be more
> > integrated with the block layer, ala drivers/block/scsi_ioctl.c
>
> Jens is probably better suited than me to comment on that.

That would by far be the superior approach. The data gathering really
does belong in the fs (it's just a larger fs block size) and would rid
the driver of the elevator hacks it's currently using. Plus all the data
gathering code, which has been notoriously buggy and hard to get right
and deadlock free (in the past at least for 2.4, I haven't worked on
this for a long time so it's not a comment on 2.6 code quality).

That would basically allow the merge of the remaining setup code into
cdrom.c. It needs someone to do the actual UDF work though... The
upside is that you would get automatic support for other devices as
well, such as the 8KiB UDO.

Ideally, someone would add support for bigger PAGE_CACHE_SIZE :)

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.016 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site