Messages in this thread | | | Date | Sun, 4 Jul 2004 10:27:50 -0700 | From | William Lee Irwin III <> | Subject | Re: move O_LARGEFILE forcing to filp_open() |
| |
On Sonntag, 4. Juli 2004 18:15, William Lee Irwin III wrote: >>> Your patch is also necessary; thanks for covering these cases.
On Sun, Jul 04, 2004 at 07:22:42PM +0200, Arnd Bergmann wrote: >> I'm not sure if you understood the intention of compat_sys_open >> right. Old 32 bit applications assume they are not using O_LARGEFILE, >> so you can't switch it on unconditionally in filp_open() for those >> cases. With your patch applied, sys_open and compat_sys_open would >> be identical again, which reverses the point of my patch. >> What is need is a way to turn on O_LARGEFILE on 64 bit archs for >> every use of filp_open _except_ from compat_sys_open.
On Sun, Jul 04, 2004 at 10:27:08AM -0700, William Lee Irwin III wrote: > Oh, that's easy, just shove the MAX_NON_LFS check into compat_sys_open().
BTW, for some reason that's what I thought you were doing in your patch.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |