Messages in this thread | | | Date | Sat, 3 Jul 2004 22:15:15 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] Update in-kernel orinoco drivers to upstream current CVS |
| |
[drivers/net/wireless/orinoco_tmd.c:orinoco_tmd_init_one] err = pci_enable_device(pdev); - if (err) - return -EIO; - - printk(KERN_DEBUG "TMD setup\n"); - pccard_ioaddr = pci_resource_start(pdev, 2); - pccard_iolen = pci_resource_len(pdev, 2); - if (! request_region(pccard_ioaddr, pccard_iolen, dev_info)) { - printk(KERN_ERR PFX "I/O resource at 0x%lx len 0x%lx busy\n", - pccard_ioaddr, pccard_iolen); - pccard_ioaddr = 0; - err = -EBUSY; - goto fail; + if (err) { + printk(KERN_ERR PFX "Cannot enable PCI device\n"); + return -err;
-> translates into err = pci_enable_device(dev); if (err) { printk(KERN_ERR PFX "Cannot enable PCI device\n"); return -err;
i.e. incorrectly returns > 0
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |