[lkml]   [2004]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [announce] HVCS for inclusion in 2.6 tree
Ryan Arnold <> wrote:

A little stylistic thing:

> + struct hvcs_struct *hvcsd = (struct hvcs_struct *)tty->driver_data;
> + struct hvcs_struct *hvcsd = (struct hvcs_struct *)tty->driver_data;
> + struct hvcs_struct *hvcsd = (struct hvcs_struct *)dev_instance;

It's not necessary to add a typecast when assigning to and from a void*.
In fact, it's harmful: if someone were to later change, say,
tty->driver_data to a `struct foo *', your typecast will suppress the
warning which we would very much like to receive.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 14:04    [W:0.225 / U:7.540 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site