lkml.org 
[lkml]   [2004]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [0/25] Merge pmdisk and swsusp
Date
On Tuesday 20 July 2004 02:28 pm, sam@ravnborg.org wrote:
> On Tue, Jul 20, 2004 at 06:46:40PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > In the end, these patches remove pmdisk from the kernel and clean up the
> > > swsusp code base. The result is a single code base with greatly improved
> > > code, that will hopefully help others underestand it better.
> >
> > Followup patch:
> >
> > * if machine halt fails, it is very dangerous to continue.
> >
> > diff -ur linux.middle/kernel/power/disk.c linux/kernel/power/disk.c
> > --- linux.middle/kernel/power/disk.c 2004-07-19 08:58:08.000000000 -0700
> > +++ linux/kernel/power/disk.c 2004-07-19 15:00:16.000000000 -0700
> > @@ -63,6 +63,9 @@
> > break;
> > }
> > machine_halt();
> > + /* Valid image is on the disk, if we continue we risk serious data corruption
> > + after resume. */
> > + while(1);
>
> Would be nicer to use:
>
> while(1)
> /* Loop forever */;
>
> Sam

And even nicer would be remove swsusp signature from swap and restore state as
original version did so user could do clean shutdown...

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [from the cache]
©2003-2011 Jasper Spaans