Messages in this thread | | | Date | Tue, 20 Jul 2004 21:21:24 +0200 | From | Pavel Machek <> | Subject | Re: [0/25] Merge pmdisk and swsusp |
| |
Hi!
> > > diff -ur linux.middle/kernel/power/disk.c linux/kernel/power/disk.c > > > --- linux.middle/kernel/power/disk.c 2004-07-19 08:58:08.000000000 -0700 > > > +++ linux/kernel/power/disk.c 2004-07-19 15:00:16.000000000 -0700 > > > @@ -63,6 +63,9 @@ > > > break; > > > } > > > machine_halt(); > > > + /* Valid image is on the disk, if we continue we risk serious data corruption > > > + after resume. */ > > > + while(1); > > > > Would be nicer to use: > > > > while(1) > > /* Loop forever */; > > > > Sam > > And even nicer would be remove swsusp signature from swap and restore state as > original version did so user could do clean shutdown...
Actually, at this point you are expected to just power down, and what you wanted is done: machine is suspended to disk.
No need to kill signature and make swsusp unusable when powerdown does not work. Pavel -- Horseback riding is like software... ...vgf orggre jura vgf serr. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |