lkml.org 
[lkml]   [2004]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6] meye driver update (wait_ms -> msleep)
Stelian Pop wrote:
> ===== drivers/media/video/meye.c 1.21 vs edited =====
> --- 1.21/drivers/media/video/meye.c 2004-03-19 07:04:56 +01:00
> +++ edited/drivers/media/video/meye.c 2004-07-02 10:58:36 +02:00
> @@ -473,16 +473,6 @@
> /* MCHIP low-level functions */
> /****************************************************************************/
>
> -/* waits for the specified miliseconds */
> -static inline void wait_ms(unsigned int ms) {
> - if (!in_interrupt()) {
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(1 + ms * HZ / 1000);
> - }
> - else
> - mdelay(ms);
> -}
> -

I was worried about in_interrupt() removal (when you unconditionally use
msleep), so I reviewed this in-depth. Looks OK to me.

ACK

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [from the cache]
©2003-2011 Jasper Spaans