Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Driver Core patches for 2.6.8-rc1 | Date | Wed, 14 Jul 2004 17:18:23 -0700 | From | Greg KH <> |
| |
ChangeSet 1.1784.12.6, 2004/07/14 16:09:44-07:00, dtor_core@ameritech.net
[PATCH] Driver core: Fix OOPS in device_platform_unregister
Driver core: platform_device_unregister should release resources first and only then call device_unregister, otherwise if there are no more references to the device it will be freed and the fucntion will try to access freed memory.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/base/platform.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff -Nru a/drivers/base/platform.c b/drivers/base/platform.c --- a/drivers/base/platform.c 2004-07-14 17:11:09 -07:00 +++ b/drivers/base/platform.c 2004-07-14 17:11:09 -07:00 @@ -146,13 +146,13 @@ int i; if (pdev) { - device_unregister(&pdev->dev); - for (i = 0; i < pdev->num_resources; i++) { struct resource *r = &pdev->resource[i]; if (r->flags & (IORESOURCE_MEM|IORESOURCE_IO)) release_resource(r); } + + device_unregister(&pdev->dev); } } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |