[lkml]   [2004]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix
    On Wed, Jul 14, 2004 at 07:39:26PM -0400, Jeff Garzik wrote:
    > ??? C does not require ordering of function _implementations_, except
    > for this gcc brokenness.

    Actually, GCC has always required that inlines be specified first
    for them to be inlined, even in earlier versions. For example, from the
    gcc 3.3 manual:

    Some calls cannot be integrated for various reasons (in particular,
    calls that precede the function's definition cannot be integrated, and
    neither can recursive calls within the definition). If there is a
    nonintegrated call, then the function is compiled to assembler code as

    > The above example allows one to do what one normally does with
    > non-inlines: order code to enhance readability, and the compiler will
    > Do The Right Thing and utilize it in the best way the CPU will function.

    I find it enhances readability to place functions in reverse order.
    That way I know I can just go to the top of a file, and the first match
    on the function's name is its definition.

    "Next the statesmen will invent cheap lies, putting the blame upon
    the nation that is attacked, and every man will be glad of those
    conscience-soothing falsities, and will diligently study them, and refuse
    to examine any refutations of them; and thus he will by and by convince
    himself that the war is just, and will thank God for the better sleep
    he enjoys after this process of grotesque self-deception." -- Mark Twain
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:04    [W:0.030 / U:5.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site