lkml.org 
[lkml]   [2004]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix
    Jeff Garzik <jgarzik@pobox.com> wrote:
    >
    > Andrew Morton wrote:
    > > Yeah, but doing:
    > >
    > > static inline foo(void);
    > >
    > > bar()
    > > {
    > > ...
    > > foo();
    > > }
    > >
    > > static inline foo(void)
    > > {
    > > ...
    > > }
    > >
    > > is pretty dumb too. I don't see any harm if this compiler feature/problem
    > > pushes us to fix the above in the obvious way.
    >
    >
    > ??? C does not require ordering of function _implementations_, except
    > for this gcc brokenness.

    Well. Other compilers had that restriction iirc, and it's a pretty natural
    thing to do.

    > The above example allows one to do what one normally does with
    > non-inlines: order code to enhance readability

    I always expect to find those little helper functions earlier in the
    compilation unit than their callsites. Pascal-style. Plus you don't have
    the hassle of keeping the declaration and definition in sync.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:04    [W:0.021 / U:0.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site