Messages in this thread | | | Date | Wed, 14 Jul 2004 22:32:58 +0200 | From | Pavel Machek <> | Subject | Re: ext3: bump mount count on journal replay |
| |
Hi!
> > Currently, you get fsck "just to be sure" once every ~30 clean > > mounts or ~30 hard shutdowns. I believe that hard shutdown is way more > > likely to cause some disk corruption, so it would make sense to fsck > > more often when system is hit by hard shutdown. > > > > What about this patch? > > > > @@ -1484,9 +1485,11 @@ > > * root first: it may be modified in the journal! > > */ > > if (!test_opt(sb, NOLOAD) && > > - EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) { > > - if (ext3_load_journal(sb, es)) > > - goto failed_mount2; > > + EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) { { > > + mount_cost = 5; > > + if (ext3_load_journal(sb, es)) > > + goto failed_mount2; > > + } > > AFAICS, this just means that if you have an ext3 filesystem > (i.e. has_journal) that you will fsck 5x as often, not so great. You > should instead check for INCOMPAT_RECOVER instead of HAS_JOURNAL.
Oops, you are right. Updated patch is attached.
> Instead, you could change this to only increment the mount count after > a clean unmount 20% of the time (randomly). Since most people bitch > about the full fsck anyways this is probably the better choice than > increasing the frequency of checks and forcing the users to change the > check interval to get the old behaviour.
Nice hack.... would that be acceptable? Pavel
-- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |