[lkml]   [2004]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix
    On Wed, Jul 14, 2004 at 12:44:44PM -0400, Jeff Garzik wrote:
    > Adrian Bunk wrote:
    > >On Wed, Jul 14, 2004 at 11:52:46AM -0400, Jeff Garzik wrote:
    > >
    > >>...
    > >>If gcc is insisting that prototypes for inlines no longer work, we have
    > >>a lot of code churn on our hands ;-( Grumble.
    > >
    > >
    > >I've counted at about 30 files with such problems in a full i386
    > >2.6.7-mm7 compile.
    > >
    > >I've already sent patches for some of them (e.g. the dmascc.c one), and
    > >they are usually pretty straightforward.
    > This is not a problem with the kernel.
    > All these files have been functioning just fine for years, with properly
    > prototyped static inline functions.

    Add -Winline to the compile flags, and name one gcc version that is able
    to inline them all in sg.c ...

    > Though there is a the claim that '#define inline always_inline' is
    > leading to all this breakage.

    gcc 3.4 is just complaining louder that it can't inline something it was
    told to inline.

    > Jeff



    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:04    [W:0.021 / U:11.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site