Messages in this thread | | | Date | Tue, 13 Jul 2004 15:44:48 -0700 | From | Andrew Morton <> | Subject | Re: [linux-audio-dev] Re: [announce] [patch] Voluntary Kernel Preemption Patch |
| |
Andrea Arcangeli <andrea@suse.de> wrote: > > On Tue, Jul 13, 2004 at 03:25:32PM -0700, Andrew Morton wrote: > > local_irq_disable(); > > <fiddle with per-cpu stuff> > > function_which_calls_cond_resched(); > > <fiddle with per-cpu stuff> > > local_irq_enable(); > > > > then we want might_sleep() to warn about the bug. > > might_sleep currently _doesn't_ warn about any bug in the above case I > quoted. > > the kmalloc example is trapped instead.
Yeah, I know. might_sleep() in cond_resched() makes sense.
> >From my part I don't like anybody to call schedule with irq disabled
I'd agree with that. But when I "fixed" it, Ingo unfixed it again and I didn't have sufficiently strong feelings either way to object.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |