Messages in this thread | | | Date | Mon, 12 Jul 2004 15:25:50 +0200 (MEST) | From | Geert Uytterhoeven <> | Subject | Re: Linux 2.6.8-rc1 |
| |
On Mon, 12 Jul 2004, OGAWA Hirofumi wrote: > Geert Uytterhoeven <geert@linux-m68k.org> writes: > > On Sun, 11 Jul 2004, Linus Torvalds wrote: > > > Hirofumi Ogawa: > > > o FAT: don't use "utf8" charset and NLS_DEFAULT > > > > This patch breaks compilation if both MSDOS_FS and VFAT_FS are not set, due to > > CONFIG_FAT_DEFAULT_CODEPAGE being undefined. > > > > Suggested fix: either make FAT_DEFAULT_CODEPAGE depend on FAT_FS only > > (compilation of fs/fat/inode.c depends on FAT_FS), or add a test for > > CONFIG_FAT_DEFAULT_CODEPAGE being undefined, cfr. the test for > > CONFIG_FAT_DEFAULT_IOCHARSET in fs/fat/inode.c. > > Why did you need only FAT_FS? If it was not needed, I'll remove the
It was a leftover in my current .config.
> configurable FAT_FS, instead it is internally used only.
If it's for internal use only, perhaps it should not be presented to the user and both MSDOS_FS and VFAT_FS should simply select it in Kconfig?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |